Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Opening Brave Privacy Reports flyout causes Brave to no longer honor rotation lock #11059

Closed
intrnl opened this issue Aug 3, 2020 · 7 comments
Labels
closed/duplicate Issue has already been reported design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Android Fixes related to Android browser functionality

Comments

@intrnl
Copy link

intrnl commented Aug 3, 2020

Description

Opening Brave Stats flyout on NTP causes Brave to no longer honor the rotation lock

Steps to reproduce

  1. Make sure auto-rotate is disabled (rotation lock)
  2. Open a new tab
  3. Open the Brave Stats flyout and close it
  4. Turn the device sideways

Actual result

The rotation lock is ignored and the screen rotates to landscape

Expected result

The rotation lock is honored and it doesn't rotate the screen

Issue reproduces how often

Easily reproduced

Issue happens on

  • Current Play Store version? 1.14.10
  • Beta build? Yes, Nightly

Device details

  • Install type (ARM, x86): arm64
  • Device (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.14.10 Nightly

Additional information

@intrnl intrnl added the OS/Android Fixes related to Android browser functionality label Aug 3, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 3, 2020

This seems expected. When device is in landscape mode there is no way to populate the stats flyout.

cc: @jamesmudgett

@srirambv srirambv added design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Aug 3, 2020
@intrnl
Copy link
Author

intrnl commented Aug 3, 2020

Brave Stats flyout forcing portrait might be expected, what's unexpected for me is that turning the device sideways after closing the flyout shouldn't have put it to landscape since I have the rotation lock.

@intrnl
Copy link
Author

intrnl commented Aug 3, 2020

I have to close the app and reopen it again just so my screen stays locked on portrait.

@bbolgradov
Copy link

I can confirm this issue. Really annoying.

@srirambv
Copy link
Contributor

srirambv commented Aug 4, 2020

Ok, I see one potential annoying factor on a tablet as well but not because of portrait. If Auto-rotate is enabled and the device is rotated 180deg in portrait mode, clicking on stats rotates it back to the original orientation

@acadet
Copy link

acadet commented Sep 15, 2020

Any update on this issue? It's happening to me as well

Brave 1.13.87, Chromium 85.0.4183.102
Android 9; ONEPLUS A3000 Build/PKQ1.181203.001

@intrnl
Copy link
Author

intrnl commented Sep 16, 2020

Should be fixed by brave/brave-core#6650

@intrnl intrnl closed this as completed Sep 16, 2020
@intrnl intrnl changed the title [Android] Opening Brave Stats flyout causes Brave to no longer honor rotation lock [Android] Opening Brave Privacy Reports flyout causes Brave to no longer honor rotation lock Sep 16, 2020
@bbondy bbondy added the closed/duplicate Issue has already been reported label Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported design A design change, especially one which needs input from the design team needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

5 participants