Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Changed access type for getSearchEngineSourceType #6272

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jul 30, 2020

This fixes crash on debug build

Resolves brave/brave-browser#11022

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 30, 2020
@samartnik samartnik added this to the 1.14.x - Nightly milestone Jul 30, 2020
@samartnik samartnik requested a review from deeppandya July 30, 2020 19:03
@samartnik samartnik self-assigned this Jul 30, 2020
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya
Copy link
Contributor

@samartnik we need to uplift it to 1.12

@samartnik samartnik merged commit 8349e9e into master Jul 30, 2020
@samartnik samartnik deleted the android_search_crash branch July 30, 2020 20:08
brave-builds pushed a commit that referenced this pull request Jul 30, 2020
samartnik pushed a commit that referenced this pull request Aug 17, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 17, 2020

Verification PASSED on Samsung S10+ running Android 10 using the following build:

Brave - Nightly 1.14.44 CR: 85.0.4183.69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Fix crash on opening search engine in debug build
3 participants