Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix crash on opening search engine in debug build #11022

Closed
samartnik opened this issue Jul 30, 2020 · 3 comments · Fixed by brave/brave-core#6272
Closed

[Android] Fix crash on opening search engine in debug build #11022

samartnik opened this issue Jul 30, 2020 · 3 comments · Fixed by brave/brave-core#6272

Comments

@samartnik
Copy link
Contributor

Description

java.lang.IllegalAccessError: Method 'int org.chromium.chrome.browser.search_engines.settings.BraveBaseSearchEngineAdapter.getSearchEngineSourceType(org.chromium.components.search_engines.TemplateUrl, org.chromium.components.search_engines.TemplateUrl)' is inaccessible to class 'org.chromium.chrome.browser.search_engines.settings.SearchEngineAdapter' (declaration of 'org.chromium.chrome.browser.search_engines.settings.SearchEngineAdapter' appears in /data/app/com.brave.browser_default-V4jE6tH96mULLXfaqAQ7TA==/base.apk!classes3.dex)
        at org.chromium.chrome.browser.search_engines.settings.SearchEngineAdapter.refreshData(SearchEngineAdapter.java:183)
        at org.chromium.chrome.browser.search_engines.settings.SearchEngineAdapter.start(SearchEngineAdapter.java:124)
        at org.chromium.chrome.browser.settings.BraveSearchEngineAdapter.start(BraveSearchEngineAdapter.java:37)
        at org.chromium.chrome.browser.settings.BraveSearchEnginePreference.onStart(BraveSearchEnginePreference.java:45)

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Jul 30, 2020
@samartnik samartnik self-assigned this Jul 30, 2020
@samartnik
Copy link
Contributor Author

Test plan: double check that you can change search engine from settings

@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2020

@samartnik does this only apply to debug builds? I don't think QA goes through debug builds. Unless it's just a double check in release builds to make sure that you can select SE from Settings without any issues 👍

@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.13.81 x64 build

  • Verified opening search setting doesn't crash the build
  • Verified changing search engine doesn't cause browser to crash

Verification passed on OnePlus 6T with Android 10 running 1.13.81 x64 build

  • Verified opening search setting doesn't crash the build
  • Verified changing search engine doesn't cause browser to crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants