-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reopen] [cr84] Settings page follow-ups: fixes guest mode, and refactors to overrides by module name #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
force-pushed
the
cr84
branch
2 times, most recently
from
July 1, 2020 22:12
268ce7b
to
4ee0d6e
Compare
Now that everything is defined in JS (with the move to es-modules), we can more declaratively define the overrides. This gives us an opportunity to make the overrides more readable, maintainable and expressed in the expected file name or the overridden component.
Use and override page visibility correctly
petemill
force-pushed
the
cr84-settings-refactor
branch
from
July 1, 2020 22:18
bd285ad
to
3435743
Compare
Everything CI passed, except |
bsclifton
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
mkarolin
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
32 tasks
bridiver
approved these changes
Jul 2, 2020
32 tasks
mkarolin
pushed a commit
that referenced
this pull request
Jul 7, 2020
[reopen] [cr84] Settings page follow-ups: fixes guest mode, and refactors to overrides by module name
Uplifted to 1.11 with #5996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening as #5976 was reverted in cr84. Android build was failing due to trying to minify the JS which was included as binary data (or maybe it was compressed). But now we have merged to master a change that prevents android compiling settings webui, which was never intended for android.
Fix brave/brave-browser#5065
Fix brave/brave-browser#2995
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.