-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cr84] Settings page follow-ups: fixes guest mode, and refactors to overrides by module name #5976
Conversation
c120758
to
a349979
Compare
might want to review commit by commit because the refactor commit confuses things due to moved files |
Wow - I think I'll need to review the changes in Chromium 84 first... because that code changed quite a bit. This cleans it up even more; love it 😄 Will circle back after checking out C84 |
@bsclifton yes I did this refactor a bit iteratively:
|
Now that everything is defined in JS (with the move to es-modules), we can more declaratively define the overrides. This gives us an opportunity to make the overrides more readable, maintainable and expressed in the expected file name or the overridden component.
Use and override page visibility correctly
3eaf2a5
to
290072c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Fix brave/brave-browser#5065
Fix brave/brave-browser#2995
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.