Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process twitter on android #5817

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Do not process twitter on android #5817

merged 1 commit into from
Jun 16, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 11, 2020

Resolves brave/brave-browser#10208

Submitter Checklist:

Test Plan:

(on android)

  • enable rewards
  • visit twitter.com
  • open a panel
  • make sure that you only see rewards summary
  • click on more links on twitter and make sure that you always see rewards summary
  • visit some other sites and make sure that pages are shown correctly in the panel

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 11, 2020
@NejcZdovc NejcZdovc self-assigned this Jun 11, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit dbb0449 into master Jun 16, 2020
@NejcZdovc NejcZdovc deleted the twitter-android branch June 16, 2020 13:44
brave-builds pushed a commit that referenced this pull request Jun 18, 2020
NejcZdovc pushed a commit that referenced this pull request Jun 18, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.38 x64 Nightly

  • Verified searching for a user and loading doesn't show tips options and only shows rewards summary
    image

  • Verified opening a tweet doesn't show tips options and only shows rewards summary
    image

  • Verified visiting a page shows tips option and allows to tip
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Disable twitter support in the panel
4 participants