Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Disable twitter support in the panel #10208

Closed
NejcZdovc opened this issue Jun 10, 2020 · 1 comment · Fixed by brave/brave-core#5817
Closed

[Android] Disable twitter support in the panel #10208

NejcZdovc opened this issue Jun 10, 2020 · 1 comment · Fixed by brave/brave-core#5817
Assignees
@NejcZdovc
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
Android 1.10.x Ho...

Comments

@NejcZdovc
Copy link
Contributor

We should check if site is twitter.com and just skip publisher being recorded if that is the case. This should only happen on Android.
@NejcZdovc NejcZdovc added feature/rewards OS/Android Fixes related to Android browser functionality labels Jun 10, 2020
@NejcZdovc NejcZdovc self-assigned this Jun 10, 2020
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 11, 2020
@NejcZdovc NejcZdovc mentioned this issue Jun 11, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 15, 2020
@NejcZdovc
Do not process twitter on android
9c0557a 
Resolves brave/brave-browser#10208
@brave-builds brave-builds mentioned this issue Jun 18, 2020
Merged
4 tasks
@NejcZdovc NejcZdovc mentioned this issue Jun 18, 2020
Merged
4 tasks
This was referenced Jun 22, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Jun 22, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on Samsung Tab A with Android 9 running 1.10.95

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.apk 1.10.95

  • Verified no tips drop down is shown on a twitter handle
    Screenshot_2020-06-22-18-44-16
  • Verified no tips drop down is shown on a tweet from a twitter handle
    Screenshot_2020-06-22-18-50-12
  • Verified tips dropdown is shown for all other websites except twitter
    Screenshot_2020-06-22-18-51-01

@kjozwiak kjozwiak mentioned this issue Jun 22, 2020
Closed
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 15, 2020
@srirambv srirambv mentioned this issue Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
Android 1.10.x Hotfix 1 Release
Development

Successfully merging a pull request may close this issue.

Do not process twitter on android brave/brave-core
5 participants
@kjozwiak @anthonypkeane @NejcZdovc @srirambv @GeetaSarvadnya