Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tint for icons #5535

Merged
merged 1 commit into from
May 12, 2020
Merged

Fixed tint for icons #5535

merged 1 commit into from
May 12, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented May 12, 2020

Resolves brave/brave-browser#9674

Submitter Checklist:

Test Plan:

brave/brave-browser#9674 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 12, 2020
@samartnik samartnik added this to the 1.10.x - Nightly milestone May 12, 2020
@samartnik samartnik self-assigned this May 12, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit b690e27 into master May 12, 2020
@samartnik samartnik deleted the android_tint_for_icons_fix branch May 12, 2020 20:13
brave-builds pushed a commit that referenced this pull request May 12, 2020
brave-builds pushed a commit that referenced this pull request May 12, 2020
@kjozwiak
Copy link
Member

Verification PASSED on Samsung Galaxy S10+ using the following build:

Brave - Nightly 1.10.54 CR: 81.0.4044.138

Went through the cases outlined under brave/brave-browser#9674 (comment).

Settings using Dark Theme

Screenshot_20200513-135721_Brave - Nightly

Screenshot_20200513-135726_Brave - Nightly

Settings using Light Theme

Screenshot_20200513-135834_Brave - Nightly
Screenshot_20200513-135840_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Icons in site settings menu are not properly tinted in dark mode
3 participants