Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Icons in site settings menu are not properly tinted in dark mode #9674

Closed
samartnik opened this issue May 7, 2020 · 1 comment · Fixed by brave/brave-core#5535

Comments

@samartnik
Copy link
Contributor

Description

Icons in site settings menu are not properly tinted in dark mode

Steps to reproduce

  1. Set dark mode
  2. Go to Site settings
  3. 2 last icons are not tinted there
    device-2020-05-07-151351

Actual result

Icons are not tinted

Expected result

Icons are tinted

Issue reproduces how often

Always

Issue happens on

  • Current Play Store version? yes
  • Beta build? yes

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.7.102

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 22, 2020

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm.apk 1.9.74

  • All the icons in the Site settings are tinted in dark mode
    Screenshot_2020-05-22-17-43-57

Verification passed on Asus Zenfone (x86) with Android 6 running BraveModernx86.apk 1.9.74

Screenshot_20200522-085951


Verification passed on BraveModernarm v1.9.74 on Samsung Galaxy Tab S5e (Android 9.0)
Screenshot_20200523-040804_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants