Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash when suggesting in Private window (1.7.x). #5257

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#9119
Uplift from #5221

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes crash when suggesting in Private window.
@mkarolin mkarolin added this to the 1.7.x - Release Hotfix 1 milestone Apr 15, 2020
@mkarolin mkarolin requested a review from a team April 15, 2020 18:12
@mkarolin mkarolin requested a review from bridiver as a code owner April 15, 2020 18:12
@mkarolin mkarolin self-assigned this Apr 15, 2020
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Apr 15, 2020
@bsclifton
Copy link
Member

CI passed on Android/Linux/Windows; going to delete brave-browser branch and rebase to pull in latest CI changes (timeouts for init). Should be good after that 😄

@mkarolin mkarolin changed the title Fixes crash when suggesting in Private window. Fixes crash when suggesting in Private window (1.7.x). Apr 15, 2020
@bsclifton
Copy link
Member

macOS passed because it was able to do a sync instead of an init; iOS still having the cloning problem

@bsclifton bsclifton added the CI/skip-macos-x64 Do not run CI builds for macOS x64 label Apr 16, 2020
@kjozwiak
Copy link
Member

QA verified #5221 on the latest Nightly as per #5221 (comment).

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit f6ccfa2 into 1.7.x Apr 16, 2020
@kjozwiak kjozwiak deleted the maxk-issue-9119-1.7.x branch April 16, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants