Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash with Google autocomplete and Private Window #9119

Closed
rebron opened this issue Apr 9, 2020 · 3 comments · Fixed by brave/brave-core#5221
Closed

crash with Google autocomplete and Private Window #9119

rebron opened this issue Apr 9, 2020 · 3 comments · Fixed by brave/brave-core#5221
Assignees
@mkarolin
Labels
crash feature/autocomplete feature/private-browsing priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Milestone
1.7.x - Release H...

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 9, 2020

Description

Instant crash with Google's autocomplete pref on and opening a New Private Window.
Crash ID: 4f71746f-6429-4691-aa1a-32107e6428e5
Crassh ID: f3634a1b-bc46-4181-b04b-cbcc5c54f647

Steps to Reproduce

  1. Turn on Autocomplete searches and URLs in brave://settings/privacy with Google as the search engine.
  2. Open New Private Window.
  3. Start typing in url bar in Private Window and notice immediate crash.

Actual result:

See str.

Expected result:

No crash with Google's new autocomplete feed in Private Window.

Reproduces how often:

Easily. CR 81 related.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.5.x or 1.7.x no.
  • Can you reproduce this issue with the beta channel?
Brave 1.8.70 Chromium: 81.0.4044.83 (Official Build) beta (64-bit)
Revision 5718ca617723806b9aacfb41108a0d911d1bde74-refs/branch-heads/4044@{#853}
OS macOS Version 10.15.5 (Build 19F53f)
  • Can you reproduce this issue with the dev channel? c81 related
  • Can you reproduce this issue with the nightly channel? Yes. 1.9.x c81 related.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. crash labels Apr 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 9, 2020

@rebron nice find 👍Reproduced using the following builds:

Brave | 1.8.69 Chromium: 81.0.4044.83 (Official Build) dev (64-bit)
-- | --
Revision | 5718ca617723806b9aacfb41108a0d911d1bde74-refs/branch-heads/4044@{#853}
OS | macOS Version 10.15.3 (Build 19D76)
  • Uploaded Crash Report ID: 35300000-9fe2-3a04-0000-000000000000
Brave | 1.9.7 Chromium: 81.0.4044.83 (Official Build) nightly (64-bit)
-- | --
Revision | 5718ca617723806b9aacfb41108a0d911d1bde74-refs/branch-heads/4044@{#853}
OS | macOS Version 10.15.3 (Build 19D76)
  • Uploaded Crash Report ID: 3d300000-9fe2-3a04-0000-000000000000

However, I can't reproduce the crash using the following build:

Brave | 1.7.90 Chromium: 80.0.3987.163 (Official Build) (64-bit)
-- | --
Revision | e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS | macOS Version 10.15.3 (Build 19D76)

Seems like C81 related as @rebron mentioned above.

@mkarolin mkarolin self-assigned this Apr 9, 2020
@bsclifton bsclifton mentioned this issue Apr 9, 2020
Closed
mkarolin added a commit to brave/brave-core that referenced this issue Apr 10, 2020
@mkarolin
Fixes crash when suggesting in Private window.
d1314b0 
Fixes brave/brave-browser#9119

When search suggestions are turned on and a user types into the omnibox
in a Private window a crash would occur. This started happening with the
upgrade to Chromium 81 because the check for BitmapFetchService bein
null has been removed in ChromeOmniboxClient::OnResultChanged (and other
places). This is because the code there isn't expected to be triggered
for an OTR profile.

Updated BraveAutocompleteProviderClient to override 2 additional
methods:

1. IsOffTheRecord
2. StartServiceWorker

These methods regulate when it is suitable to make suggestions and
should use the real profile (OTR or regular) instead of using regular
profile that we send to the base class even when the profile is OTR.
@mkarolin mkarolin mentioned this issue Apr 10, 2020
Merged
32 tasks
@kjozwiak kjozwiak added this to the 1.7.x - Release Hotfix 1 milestone Apr 15, 2020
@kjozwiak
Copy link
Member

I can still reproduce this on 1.7.95 CR: 81.0.4044.92 which is the latest RC for the next release. We'll need to make sure this is uplifted into 1.7.x before we release on April 20th. Moved into https://github.com/brave/brave-browser/milestone/102.

Used the following build to reproduce on Win:

Brave | 1.7.95 Chromium: 81.0.4044.92 (Official Build) (64-bit)
-- | --
Revision | e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS | Windows 10 OS Version 1909 (Build 18363.752)

This was referenced Apr 15, 2020
Merged
Merged
This was referenced Apr 20, 2020
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Apr 20, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Linux
  • Verified no crash when typing in URL on a private tab
  • Verified no crash when typing in URL on a private Tor tab
  • Verified no crash when typing in URL on a guest tab

Verification passed on

Brave 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Clean profile:

  • Verified no crash when typing in URL on a private tab
  • Verified no crash when typing in URL on a private Tor tab
  • Verified no crash when typing in URL on a guest tab
  • Verified no crash when typing in URL on a New Window

Upgraded profile: ( 1.7.95 to 1.7.98)

  • Verified no crash when typing in URL on a private tab
  • Verified no crash when typing in URL on a private Tor tab
  • Verified no crash when typing in URL on a guest tab
  • Verified no crash when typing in URL on a New Window

Verified passed with

Brave 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)
  • Reproduced the issue with 1.7.95 using STR from description. Confirmed no crash on 1.7.98 using same STR.

Clean profile:

  • Verified no crash when typing in URL on a private tab
  • Verified no crash when typing in URL on a private Tor tab
  • Verified no crash when typing in URL on a guest tab
  • Verified no crash when typing in URL on a New Window

Upgraded profile: (1.7.95 to 1.7.98)

  • Verified no crash when typing in URL on a private tab
  • Verified no crash when typing in URL on a private Tor tab
  • Verified no crash when typing in URL on a guest tab
  • Verified no crash when typing in URL on a New Window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
crash feature/autocomplete feature/private-browsing priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.7.x - Release Hotfix 1
Development

Successfully merging a pull request may close this issue.

Fixes crash when suggesting in Private window. brave/brave-core
6 participants
@kjozwiak @rebron @srirambv @LaurenWags @GeetaSarvadnya @mkarolin