Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cosmetic filtering by default #4511

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Feb 5, 2020

Changes flag introduced by #4269 to be enabled by default. Needs uplifting to 1.5.x.

Fixes brave/brave-browser#8068

Depends on #4585.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@antonok-edm antonok-edm self-assigned this Feb 5, 2020
@pes10k
Copy link
Contributor

pes10k commented Feb 5, 2020

I see a CI error, but the error log doesn't look related to the change at all (auth error with github). The content of the change looks correct to me, but someone more familiar with the CI system should give it the final 👍

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@petemill petemill merged commit e7cb37e into master Feb 14, 2020
@petemill petemill deleted the cosmetic-filtering-on-by-default branch February 14, 2020 19:28
@bsclifton bsclifton added this to the 1.6.x - Nightly milestone Feb 14, 2020
@bsclifton
Copy link
Member

Great job all! 🎉

@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic filtering should be enabled by default
5 participants