Cosmetic filtering should be enabled by default

[antonok-edm]

Description

Currently merged implementation of cosmetic filtering is off by default, new 1p/3p heuristics should allow it to be enabled by default.

Test plan

See #5381

[bsclifton]

@antonok-edm what is a quick way to tell if cosmetic filtering is enabled? Is there a specific page you can mention (maybe edit the original post above to provide the example as a test plan)

[szaimen]

I am wondering, too...
Also it seem to doesn't work on some sites. Or is there a learning curve?

[bsclifton]

cc: @antonok-edm @ryanbr @snyderp

@szaimen I believe the rules are downloaded as part of the regular adblock definition download and then they should be applied. As this was just merged, it's only enabled on Nightly

Which version of Brave are you using? If you're on Developer, it may also be available, but you'd need to go to brave://flags/#brave-adblock-cosmetic-filtering to enable it

It's not merged to Beta (1.4.x) or Release (1.3.x) yet

[kjozwiak]

@bsclifton @antonok-edm is there a test plan that QA can run through to make sure this is working as expected?

[bsclifton]

@kjozwiak yup! Added 😄

[LaurenWags]

Verified passed with

Brave	1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Implement cosmetic blocking [tracking] #5381 without changing the brave://flags/#brave-adblock-cosmetic-filtering flag

Verification passed on

Brave	1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	Ubuntu 18.04 LTS

• Verified test plan from Implement cosmetic blocking [tracking] #5381 without changing the brave://flags/#brave-adblock-cosmetic-filtering flag

---

Verification passed on

Brave	1.7.86 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	Windows 10 OS Version 1803 (Build 17134.523)

• Verified test plan from Implement cosmetic blocking [tracking] #5381 without changing the brave://flags/#brave-adblock-cosmetic-filtering flag