Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mac package name being uploaded #451

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Update Mac package name being uploaded #451

merged 2 commits into from
Sep 20, 2018

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Sep 14, 2018

Fixes brave/brave-browser#1129

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mbacchi mbacchi requested a review from RyanJarv September 14, 2018 17:19
@bbondy
Copy link
Member

bbondy commented Sep 17, 2018

This might need to change depending on if dev channel will retain the dashes or not.

@mbacchi mbacchi requested a review from bkero September 19, 2018 18:56
bkero
bkero approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@bkero bkero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mihaiplesa mihaiplesa self-requested a review September 19, 2018 21:18
@mbacchi mbacchi merged commit 3bf111c into master Sep 20, 2018
@mbacchi mbacchi deleted the issue1129 branch September 20, 2018 20:44
@mbacchi
Copy link
Contributor Author

mbacchi commented Sep 20, 2018 •
edited by NejcZdovc
Loading

0.55.x: 2372507

mbacchi added a commit that referenced this pull request Sep 20, 2018
@mbacchi
Merge pull request #451 from brave/issue1129
2372507 
Update Mac package name being uploaded
@bbondy
Copy link
Member

bbondy commented Sep 22, 2018

Added milestone to closed issue.

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkero bkero bkero approved these changes

@mihaiplesa mihaiplesa mihaiplesa approved these changes

@RyanJarv RyanJarv Awaiting requested review from RyanJarv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Update upload.py script to handle new darwin package name
4 participants
@mbacchi @bbondy @bkero @mihaiplesa