Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload.py script to handle new darwin package name #1129

Closed
mbacchi opened this issue Sep 14, 2018 · 0 comments · Fixed by brave/brave-core#451
Closed

Update upload.py script to handle new darwin package name #1129

mbacchi opened this issue Sep 14, 2018 · 0 comments · Fixed by brave/brave-core#451
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@mbacchi
Copy link
Contributor

mbacchi commented Sep 14, 2018

PR brave/brave-core#437 was just merged, removing the dashes from the PRODUCT_FULLNAME, which will mean the dmg file name will no longer have dashes.

The upload.py script currently looks for a file with dashes, so we need to change that to make it work again with this new file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update Mac package name being uploaded brave/brave-core
2 participants
@bbondy @mbacchi