Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are not formatted correctly for AC(uplift to 1.3.x) #4381

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

NejcZdovc
Copy link
Contributor

Uplift of #4133
Uplift of #4300
Fixes brave/brave-browser#7185
Fixes brave/brave-browser#7562

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.3.x - Beta milestone Jan 16, 2020
@NejcZdovc NejcZdovc requested a review from a team January 16, 2020 16:28
@NejcZdovc NejcZdovc self-assigned this Jan 16, 2020
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jan 16, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. PR has been checked on Nightly by @NejcZdovc and @LaurenWags also went through on Nightly using #4133 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit d6ad509 into 1.3.x Jan 17, 2020
@kjozwiak kjozwiak deleted the issues/7185-1.3 branch January 17, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants