Fixes notification amount #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
notification-amount
branch
from
03cd66d to
aadf661
Compare
tmancey
reviewed
Jan 3, 2020
| export const handleContributionAmount = (amount: string) => { | ||
| let result = '0.0' | ||
| const amountSplit = amount.split('.') | ||
| if (amountSplit && amountSplit[0].length > 18) { |
There was a problem hiding this comment.
>= 19 would be easier to read as probi are always 19 characters
There was a problem hiding this comment.
>= 19 and > 18 both tell you that we are looking for number 19. Personally I like to avoid >= as it's really easy to miss when reading through stuff
There was a problem hiding this comment.
Easier to read if the magic number is replaced
tmancey
reviewed
Jan 3, 2020
| let result = '0.0' | ||
| const amountSplit = amount.split('.') | ||
| if (amountSplit && amountSplit[0].length > 18) { | ||
| const result = new BigNumber(amount).dividedBy('1e18').toFixed(1, BigNumber.ROUND_DOWN) |
There was a problem hiding this comment.
Monetary amounts are normally rounded up, is this correct to round down?
There was a problem hiding this comment.
Based upon being correct, see comment below for test
tmancey
reviewed
Jan 3, 2020
NejcZdovc
force-pushed
the
notification-amount
branch
from
aadf661 to
8dbeee6
Compare
tmancey
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7562
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.