Replace bookmark manager empty list string #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
commented
Jan 10, 2020
| content::WebUIDataSource::Create(chrome::kChromeUIBookmarksHost); | ||
| @@ -174,6 +174,7 @@ content::WebUIDataSource* CreateBookmarksUIHTMLSource(Profile* profile) { | ||
|
|
||
| source->UseStringsJs(); | ||
|
|
||
| + BraveCustomizeBookmarksDataSource(source); |
There was a problem hiding this comment.
Moved BraveCustomizeBookmarksDataSource(source) to the last of CreateBookmarksUIHTMLSource() to get a chance to replace already added strings.
There was a problem hiding this comment.
can you convert this to a define since you're changing it anyway?
|
Only unrelated steps ( |
petemill
approved these changes
Jan 14, 2020
|
@bridiver ping for owners review :) |
simonhong
force-pushed
the
update_empty_bookmark_list_sentence
branch
3 times, most recently
from
2c943d7 to
7eade77
Compare
simonhong
force-pushed
the
update_empty_bookmark_list_sentence
branch
from
7eade77 to
f2cb533
Compare
bridiver
approved these changes
Jan 15, 2020
simonhong
added
CI/skip-android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#2494
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.