-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update wording on bookmark manager and favicon to remove reference to star icon #2494
Comments
Text should be: To bookmark pages, click the bookmarks button next to the address bar. |
cc: @petemill can you take at look if you're in brave://bookmarks already. |
@LaurenWags this bookmark button on the left side of the location bar, it's turning the transition experience a bit annoying. There's any chance to change it. 😒 |
@eltonbaroncello I'm not aware of any plans to move the location of the bookmark button. |
Let's also address the favicon in the Bookmarks tab at the top by using our bookmarks icon. |
DM'd Raf: copy finalized to : |
Verification passed on
Verified passed with
Reproduced original issue with 1.4.95: Updated to 1.5.105 and confirmed text matches #2494 (comment):
Verification passed on
|
Description
When you navigate to the bookmarks manager and you don't have any bookmarks yet (or you navigate to a folder within bookmark manager that does not have any bookmarks) you're shown instructional text that says 'To bookmark pages, click the star in the address bar' - however, there's no star for you to click as we changed icons. This wording should be updated to reflect changed icon.
Steps to Reproduce
Actual result:
Expected result:
Text should be updated to reflect changed icon.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: