Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards Settings Design/Text Updates (0.71) #3841

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 31, 2019

@ryanml ryanml added this to the 0.71.x - Beta milestone Oct 31, 2019
@ryanml ryanml requested a review from a team October 31, 2019 19:06
@ryanml ryanml requested a review from NejcZdovc as a code owner October 31, 2019 19:06
@ryanml ryanml self-assigned this Oct 31, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Nov 1, 2019

Restarting Linux due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3727-71/1/execution/node/413/log/:

17:24:25  Xlib:  extension "XInputExtension" missing on display ":3".
17:24:25  [22565:22612:1031/212423.600429:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
17:24:25  [22565:22612:1031/212423.614304:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
17:24:25  [22565:22612:1031/212423.614331:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
17:24:25  [22565:22625:1031/212423.680040:ERROR:rewards_service_impl.cc(198)] Failed to read file: /home/ubuntu/.config/BraveSoftware/brave-network-test/Default/ledger_state
17:24:25  [22623:22623:1031/212423.685778:ERROR:ledger_impl.cc(102)] Failed to initialize wallet
17:25:32  [22565:22565:1031/212523.603372:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
17:25:54  [22565:22565:1031/212552.660014:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
17:26:09  undefined:16145
17:26:09  {"phase":2,"source":{"id":17,"type":8}]}
17:26:09                                        ^
17:26:09  
17:26:09  SyntaxError: Unexpected token ] in JSON at position 49814060
17:26:09      at JSON.parse (<anonymous>)
17:26:09      at start (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3727-71/lib/start.js:144:23)
17:26:09      at Command.listener (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3727-71/node_modules/commander/index.js:315:8)
17:26:09      at Command.emit (events.js:210:5)
17:26:09      at Command.parseArgs (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3727-71/node_modules/commander/index.js:654:12)
17:26:09      at Command.parse (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3727-71/node_modules/commander/index.js:474:21)
17:26:09      at Object.<anonymous> (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3727-71/scripts/commands.js:155:4)
17:26:09      at Module._compile (internal/modules/cjs/loader.js:956:30)
17:26:09      at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
17:26:09      at Module.load (internal/modules/cjs/loader.js:812:32)

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Nov 1, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being added and the associated issue is moved into the correct milestone.

Rewards Settings Design/Text Updates
@bsclifton bsclifton merged commit d4082ad into 0.71.x Nov 1, 2019
@bsclifton bsclifton deleted the uplift-3727-71 branch November 1, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants