-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tip panel wording - follow up to 6228 #6484
Comments
cc @jenn-rhim |
@LaurenWags @ryanml @mandar-brave Here is the new text: Monthly Contributions Your monthly contributions will be sent every 30 days. Tips Tip on the spot as you find gems. If you like, let people know with a quick tweet. |
@bsclifton @ryanml @kjozwiak Should this be uplifted to 0.71.x? 0.71.x uses old Rewards layout. It doesn't even have |
@rebron ^ |
again I don't know why this was uplifted to 0.71 as original implementation was done in 0.72. What we now uplifted in not relevant to .71 |
Per discussion in todays triage mtg, we are keeping these text changes in 0.71.x. Verified Tips panel text with 0.71.x:
Verified Monthly Contributions panel text with 0.72.x as it is not available in 0.71.x:
Verification passed on
Verification passed on
Verification passed on
Verification passed on
|
Description
With the changes in #6228 and #6288, and a new
Monthly Contribution
panel on brave://rewards, should the Tip panel text which mentions recurring monthly tips be updated?Steps to Reproduce
Actual result:
Expected result:
Unsure if text should be updated or removed.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @davidtemkin @NejcZdovc @rebron @kjozwiak
The text was updated successfully, but these errors were encountered: