Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards Settings Design/Text Updates (0.72) #3840

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Rewards Settings Design/Text Updates (0.72) #3840

merged 1 commit into from
Nov 1, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 31, 2019

@ryanml ryanml added this to the 0.72.x - Dev milestone Oct 31, 2019
@ryanml ryanml requested a review from a team October 31, 2019 19:04
@ryanml ryanml requested a review from NejcZdovc as a code owner October 31, 2019 19:04
@ryanml ryanml self-assigned this Oct 31, 2019
kjozwiak
kjozwiak approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being added and the associated issue is moved into the correct milestone.

@ryanml
Merge pull request #3727 from brave/design-updates
07b3ef9 
Rewards Settings Design/Text Updates
@bsclifton bsclifton merged commit 48325f9 into 0.72.x Nov 1, 2019
@bsclifton bsclifton deleted the uplift-3727-72 branch November 1, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@ryanml ryanml

Labels
feature/rewards
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @kjozwiak @bsclifton