Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opening new regular, private, private with Tor window in Tor window (uplift to 0.72.x) #3818

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 30, 2019

Uplift of #3813

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 30, 2019
@brave-builds brave-builds added this to the 0.72.x - Dev milestone Oct 30, 2019
@yrliou
Copy link
Member

yrliou commented Oct 30, 2019

https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3813_fix_browser_commands_syntax_in_tor_0.72.x/1/ only failed at Windows-x64 with init error: WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\x07dministrator', I'm going to set skip label on other platforms to retry on Windows only.

@yrliou yrliou added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 30, 2019
@yrliou
Copy link
Member

yrliou commented Oct 30, 2019

Window passed on retry, changes were also tested using downloaded nightly 0.73.41 on macOS and the test plan worked on my end.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any failures.

Please make sure that all the appropriate labels are added and the associated issue is moved into the correct milestone.

@yrliou yrliou merged commit 5800561 into 0.72.x Oct 31, 2019
@yrliou yrliou deleted the pr3813_fix_browser_commands_syntax_in_tor_0.72.x branch October 31, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants