Support opening new regular, private, private with Tor window in Tor window #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…window. New window, New private window, New private window with Tor are shown in the hamburger and file menu, and users could use them to open any type of new window in Tor window.
yrliou
commented
Oct 29, 2019
Comment on lines
+31
to
+34
| if (brave::IsTorProfile(browser->profile())) { | ||
| chrome::NewEmptyWindow(browser->profile()); | ||
| return; | ||
| } |
There was a problem hiding this comment.
If we're already in Tor window, open a new empty Tor window.
yrliou
commented
Oct 29, 2019
Comment on lines
+82
to
+84
| InsertItemWithStringIdAt(GetIndexOfCommandId(IDC_NEW_INCOGNITO_WINDOW) + 1, | ||
| IDC_NEW_OFFTHERECORD_WINDOW_TOR, | ||
| IDS_NEW_OFFTHERECORD_WINDOW_TOR); |
There was a problem hiding this comment.
Show this option in Tor window too.
This was referenced Oct 29, 2019
|
CI failed on linux network audit with known error which is success in previous build. |
brave-builds
pushed a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#6467
Fix brave/brave-browser#6646
Per slack discussion, our goal here is to let users open all types of new windows (regular / private / private with Tor) in the hamburger and file menu in regular, private, and Tor Windows.
As screenshot below,
New Window,New Private Window, andNew Private Window with Torare shown in the hamburger menu of these three types of window, and it will open the corresponding type of new window through any of the options.regular:
private:
private with Tor:
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
New Window,New Private Window,New Private Window with Torin the hamburger menu, it should create the corresponding type of new window.New Window,New Private Window,New Private Window with Torin the hamburger menu, it should create the corresponding type of new window.New Window,New Private Window,New Private Window with Torin the hamburger menu, it should create the corresponding type of new window.Reviewer Checklist:
After-merge Checklist:
changes has landed on.