Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Korean translation of a Shields Panel string. #3660

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#6057

Decided to pull in just this translation instead of pulling in all localization changes from Transifex to minimize the impact on the hotfix.

Submitter Checklist:

Test Plan:

See image in the brave/brave-browser#6057

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 0.69.x - next release milestone Oct 10, 2019
@mkarolin mkarolin requested a review from bsclifton October 10, 2019 19:06
@mkarolin mkarolin self-assigned this Oct 10, 2019
@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Oct 10, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 1e8d630 into 0.69.x Oct 10, 2019
@bsclifton bsclifton deleted the maxk-fix-ko-l10n branch October 10, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants