Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean language menu translation error #6057

Closed
jiyongwoo opened this issue Sep 18, 2019 · 13 comments
Closed

Korean language menu translation error #6057

jiyongwoo opened this issue Sep 18, 2019 · 13 comments
Assignees
Labels

Comments

@jiyongwoo
Copy link

Description

In Shields panel,
All cookies allowed --Korean--> 모든 쿠키 차단됨(x)
--Korean--> 모든 쿠키 허용됨(o)

Actual result:

"모든 쿠키 차단됨" menu
image

Expected result:

"모든 쿠키 허용됨" menu

Brave version (brave://version info)

Brave | 0.68.138 Chromium: 77.0.3865.75 (공식 빌드) (64비트)
OS | Windows 10 OS Version 1903 (Build 18362.356)

@rebron
Copy link
Collaborator

rebron commented Sep 19, 2019

cc: @simonhong For a quick glance on translation correctness. @atsyed87 will take care of the rest.

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 20, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 1, 2019

@atsyed87 It looks like the translations are reversed.

@atsyed87
Copy link

atsyed87 commented Oct 1, 2019

Taking a look now

@simonhong
Copy link
Member

@rebron @atsyed87 Oops, sorry forgot to reply.
Yes, they are reversed.

All cookies allowed should be 모든 쿠키 허용됨

@atsyed87
Copy link

atsyed87 commented Oct 1, 2019

@simonhong I can't locate these strings inside Transifex. By any chance would you have a link to the corresponding Transifex issues?

@simonhong
Copy link
Member

simonhong commented Oct 1, 2019

@atsyed87 I'm also finding where brave_extension/_locales/ko/messages.json came from Transifex. but can't find now. Maybe other person knows about this?
@mkarolin Can you advice where that files come from?

@atsyed87
Copy link

atsyed87 commented Oct 2, 2019

cc @cezaraugusto if he knows where these might be lurking :)

@simonhong
Copy link
Member

@mkarolin Thanks! I modified its translation. Do we just need to wait next release for applying it into brave-core?

@mkarolin
Copy link
Contributor

mkarolin commented Oct 3, 2019

Could do an npm run pull_l10n to get the latest localization and uplift. cc: @bsclifton

@bsclifton
Copy link
Member

@mkarolin let's do it! I believe you've already requested one with 0.78 😄

@bsclifton
Copy link
Member

Fixed in 0.69.x with brave/brave-core#3660

@mkarolin this will be fixed in master/0.71/0.70 when translations are pulled for Chromium 78, right?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 11, 2019

Verification passed on

Brave 0.69.134 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan mentioned in the description
    image

Verified passed with

Brave 0.69.135 Chromium: 77.0.3865.120 (공식 빌드) (64비트)
개정 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS 버전 10.13.6(빌드 17G5019)
  • Verified test plan from description

Screen Shot 2019-10-11 at 오전 8 25 14

Screen Shot 2019-10-11 at 오전 8 27 47

Verification passed on

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Ubuntu 18.04 LTS
  • Verified test plan from description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants