Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes disconnected overlay from panel/page #3336

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 4, 2019

Resolves brave/brave-browser#5862

UI PR: brave/brave-ui#531

Submitter Checklist:

Test Plan:

  • enable rewards and claim grant
  • connect to uphold
  • click on wallet button in the panel/settings page
  • disconnect
  • make sure that you see anon amount and claimed grants in the panel/settings page

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Sep 4, 2019
@NejcZdovc NejcZdovc requested a review from a team September 4, 2019 08:34
@NejcZdovc NejcZdovc self-assigned this Sep 4, 2019
tmancey
tmancey previously approved these changes Sep 4, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving wallet state to browser wallet: multiple states land to this state
3 participants