Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISSING: walletGoToVerifyPage on Verify Wallet drop down from panel - follow up to 5772 #5888

Closed
LaurenWags opened this issue Sep 4, 2019 · 2 comments

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #5772

When clicking on the Verify Wallet drop down from the panel when you have a connected but not KYC'd wallet, shows:
Screen Shot 2019-09-04 at 2 49 52 PM

It should match brave://rewards page which says 'Complete wallet verification'

Steps to Reproduce

  1. Clean profile 0.69.123
  2. Enable rewards, create Uphold acct or link a non-KYC'd account
  3. Click on BAT logo
  4. Click on 'Verify Wallet'

Actual result:

Screen Shot 2019-09-04 at 2 49 52 PM

Expected result:

Screen Shot 2019-09-04 at 2 45 18 PM

Reproduces how often:

easily

Brave version (brave://version info)

0.69.123

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure, probably yes
  • Can you reproduce this issue with the nightly channel? unsure, probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @mandar-brave @NejcZdovc

@NejcZdovc
Copy link
Contributor

closing as it was fixed with brave/brave-core#3336

@NejcZdovc NejcZdovc added this to the 0.69.x - Release milestone Sep 4, 2019
@NejcZdovc NejcZdovc self-assigned this Sep 4, 2019
@btlechowski
Copy link

btlechowski commented Sep 5, 2019

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified test plan from brave/brave-core#3336

Connected wallet (not KYCed)
Panel
image
brave://rewards
image

Disconnected wallet (not KYCed)
Panel
image

brave://rewards
image

Verified that by clicking Disconnected, uphold page was opened to reconnect the wallet.
Verified that reconnecting wallet was successful.

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified STR from description
  • Verified that clicking on each option produced expected result
    Screen Shot 2019-09-05 at 11 49 51 AM

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified STR from the description
  • Verified that clicking on each option produced expected result

Disconnect wallet for not KYC'd account:
image

image

Disconnect wallet for KYC'd account:
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment