Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to disconnect from Uphold if KYC is not completed #5772

Closed
LaurenWags opened this issue Aug 22, 2019 · 3 comments · Fixed by brave/brave-core#3322
Closed

unable to disconnect from Uphold if KYC is not completed #5772

LaurenWags opened this issue Aug 22, 2019 · 3 comments · Fixed by brave/brave-core#3322

Comments

@LaurenWags
Copy link
Member

Description

If you connect an uphold account but don't KYC, you are unable to disconnect from Uphold within Rewards.

Steps to Reproduce

  1. Clean profile or upgrade to 0.69.x
  2. Enable Rewards.
  3. Click on Verify wallet from somewhere, then proceed to uphold.
  4. Create an account, don't complete KYC.
  5. Go back to Rewards Settings.
  6. Clicking on 'Verify Wallet' button doesn't give you the option to disconnect, just directs you to Uphold to complete KYC.

Actual result:

Clicking on 'Verify Wallet' takes you to Uphold to complete KYC.

Expected result:

Some way to disconnect from within Brave. If you've verified and KYC'd, clicking on 'Verify' gives you the option to disconnect:
image (1)

Not sure if we want this in the same place or somewhere different.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.69.113 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @mandar-brave

@NejcZdovc
Copy link
Contributor

this is a problem because we removed connected state. We need to decide if we want to add it back or just add dialog which you get when you are KYC'ed

@NejcZdovc
Copy link
Contributor

We should display this

image

@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 4, 2019

Verified passed with

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified test plan from Adds options for connected state brave-core#3322
  • Verified clicking on Complete wallet verification took me to Uphold in the same tab to complete my KYC
  • Verified clicking on Go to my Uphold account took me to my Uphold dashboard in the same tab
  • Verified clicking on Disconnect from Brave Rewards put me in disconnected state.
  • Verified from brave://rewards and panel

image

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from Adds options for connected state brave-core#3322
  • Verified clicking on Complete wallet verification took me to Uphold in the same tab to complete my KYC
  • Verified clicking on Go to my Uphold account took me to my Uphold dashboard in the same tab
  • Verified clicking on Disconnect from Brave Rewards put me in the disconnected state.
  • Verified from brave://rewards and panel
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment