Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds development env #3294

Merged
merged 5 commits into from
Oct 21, 2019
Merged

Adds development env #3294

merged 5 commits into from
Oct 21, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 29, 2019

Resolves brave/brave-browser#5722

Submitter Checklist:

Test Plan:

  • Confirm all Brave Rewards server communications work as expected for the server development environment (--brave-ads-development --rewards=development=true command-line arg)
  • Confirm all Brave Rewards server communications work as expected for the server staging environment (--brave-ads-staging --rewards=staging=true command-line arg)
  • Confirm all Brave Rewards server communications work as expected for the server production environment

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc
Copy link
Contributor Author

cc @tmancey for ads work

@kylehickinson
Copy link
Collaborator

@tmancey Any ETA on this?

@tmancey
Copy link
Collaborator

tmancey commented Sep 30, 2019

@kylehickinson This work is blocked awaiting development URLs, @NejcZdovc do we have an eta please?

@NejcZdovc NejcZdovc force-pushed the dev-env branch 2 times, most recently from 8c5bafc to ff277a0 Compare October 8, 2019 16:24
@tmancey tmancey force-pushed the dev-env branch 4 times, most recently from 2283907 to 44f2498 Compare October 18, 2019 16:27
@tmancey tmancey force-pushed the dev-env branch 4 times, most recently from 2217e35 to d2445af Compare October 18, 2019 21:34
@tmancey tmancey self-requested a review October 19, 2019 07:03
@NejcZdovc NejcZdovc marked this pull request as ready for review October 19, 2019 07:06
@NejcZdovc NejcZdovc added this to the 0.73.x - Nightly milestone Oct 19, 2019
@tmancey
Copy link
Collaborator

tmancey commented Oct 19, 2019

@tmancey Any ETA on this?

@kylehickinson work completed on libs, changes need to be applied to iOS

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes will be pulled in once merged

@NejcZdovc
Copy link
Contributor Author

CI passed as it only failed on audit-deps and this is expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

point browser to dev environment
3 participants