-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds development env #3294
Adds development env #3294
Conversation
vendor/bat-native-ledger/src/bat/ledger/internal/static_values.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/static_values.h
Outdated
Show resolved
Hide resolved
cc @tmancey for ads work |
@tmancey Any ETA on this? |
@kylehickinson This work is blocked awaiting development URLs, @NejcZdovc do we have an eta please? |
8c5bafc
to
ff277a0
Compare
2283907
to
44f2498
Compare
2217e35
to
d2445af
Compare
@kylehickinson work completed on libs, changes need to be applied to iOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes will be pulled in once merged
Updated development URLs for ads and confirmations
CI passed as it only failed on |
Resolves brave/brave-browser#5722
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
--brave-ads-development --rewards=development=true
command-line arg)--brave-ads-staging --rewards=staging=true
command-line arg)Reviewer Checklist:
After-merge Checklist:
changes has landed on.