Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point browser to dev environment #5722

Closed
maikelmclauflin opened this issue Aug 19, 2019 · 5 comments · Fixed by brave/brave-core#3294
Closed

point browser to dev environment #5722

maikelmclauflin opened this issue Aug 19, 2019 · 5 comments · Fixed by brave/brave-core#3294

Comments

@maikelmclauflin
Copy link

maikelmclauflin commented Aug 19, 2019

Description

feature request

ability to point browser to dev envrionment --rewards=staging=true (need dev version of this and others like it)

Expected result:

points urls to provided dev environments @hspencer77 , @bkero , @amirsaber , and i have relevant domains

@maikelmclauflin
Copy link
Author

maikelmclauflin commented Aug 19, 2019

domains known so far are

ads: http://ads-alb-1745180096.us-west-2.elb.amazonaws.com/
balance: https://bat-balance-dev.herokuapp.com/ -> mercury -> https://balance-dev.mercury.basicattentiontoken.org
ledger: https://bat-ledger-dev.herokuapp.com/ -> mercury -> https://ledger-dev.mercury.basicattentiontoken.org

are there others that are needed? these may also change if we can get a domain for ads-dev

tied to brave/devops#1537

@NejcZdovc NejcZdovc added dev-setup priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Aug 20, 2019
@NejcZdovc
Copy link
Contributor

yes we need https://publishers.basicattentiontoken.org and https://publishers-distro.basicattentiontoken.org as well

@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Aug 29, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 29, 2019
@NejcZdovc NejcZdovc removed their assignment Sep 5, 2019
@NejcZdovc NejcZdovc removed this from the 0.70.x - Beta milestone Sep 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 8, 2019
@jsecretan jsecretan added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 21, 2019
@NejcZdovc NejcZdovc added this to the 0.73.x - Nightly milestone Oct 21, 2019
@NejcZdovc NejcZdovc self-assigned this Oct 21, 2019
@LaurenWags
Copy link
Member

@NejcZdovc @tmancey Could one of you provide a test plan for this issue please?

@tmancey
Copy link
Contributor

tmancey commented Nov 22, 2019

@LaurenWags Test plan added to brave/brave-core#3294

@btlechowski
Copy link

btlechowski commented Nov 27, 2019

Verified passed with

Brave 1.2.11 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3294

--brave-ads-development

  • Verified enabling of rewards
  • Verified wallet was created successfully
  • ads urls points to dummy ads-serve.brave.software.com server
  • ads grant is shown by default
    image
  • Was unable to claim the grant
    image
  • ads catalog was not downloaded, because it points to dummy https://ads-serve.brave.software.com/v1/catalog

Logged #7132 for the above issues

--brave-ads-staging
Verified enabling of rewards
Verified wallet was created successfully
Verified that UGP grant is shown by default
image
Verified that I was able to claim the grant
image
image
Verified that got staging ads catalog
Verified that was able to tip a verified creator
Verified that wallet was updated after tipping
Verified that I got an ad

production
Verified enabling of rewards
Verified wallet was created successfully
Verified that got production ads catalog
Verified that was able to tip a verified creator
Verified that wallet was updated after tipping
Verified that I got an ad

Verification passed on

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Production

  • Verified that ads catalog gets downloaded as expected and which points to the expected endpoint
  • Verified that A-C, Monthly contributions, One-time tips works as expected
  • Verified that Ads are received based on the frequency of the ads set in the Ads panel
  • Verified Ads end to end in the manual test run

--brave-ads-staging

  • Verified enabling rewards created the wallet successfully
  • Verified able to claim UGP grants and confirmed A-C happened successfully
  • Verified able to claim ad grants
  • Verified that staging ads catalog is downloaded and ads notifications are received for US region
  • Verified able to tip KYC'd creator
  • Verified wallet balance updated after tip completed
Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified test plan from Adds development env brave-core#3294

  • Dev Rewards env

  • Beta Rewards env

    • Verified enabling rewards
    • Verified wallet created successfully
    • Verified able to claim UGP grant
    • Verified able to claim Ad grant
    • Verified download of staging Ads catalog
    • Verified ad notification received
    • Verified able to tip KYC'd creator
    • Verified wallet balance updated after tip completed
    • Verified able to do an auto contribute
  • Prod Rewards env

    • Verified enabling rewards
    • Verified wallet created successfully
    • Verified download of prod Ads catalog
    • Verified Ad notification received
    • Verified able to tip KYC'd creator
    • Verified wallet balance updated after tip completed
    • Verified able to do an auto contribute
    • Unable to check claiming UGP and Ad grants
      Note - while testing saw that balances were taking a long time to update in the browser - possible server issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants