Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Clear Browsing Data dialog not showing. #2945

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix for Clear Browsing Data dialog not showing. #2945

merged 1 commit into from
Jul 18, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 17, 2019 •
edited by bsclifton
Loading

Fixes brave/brave-browser#5277

Submitter Checklist:

Test Plan:

See STR in brave/brave-browser#5277

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 0.69.x - Nightly milestone Jul 17, 2019
@mkarolin mkarolin self-assigned this Jul 17, 2019
@mkarolin mkarolin force-pushed the maxk-fix-clear-browsing-data branch from ab76b2c to 4731d3c Compare July 17, 2019 21:42
@mkarolin
Fix for Clear Browsing Data dialog not showing.
7ec1cf4 
Fixes brave/brave-browser#5277

Previously, each paper-tab was explicitly added in the html to
paper-tabs element. Now, cr-tabs element just needs tab names, which is done
in JS.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/6aea076147cf76991b848d4424c3f267ccd87679

commit 6aea076147cf76991b848d4424c3f267ccd87679
Author: Esmael El-Moslimany <[email protected]>
Date:   Fri May 17 19:04:17 2019 +0000

    Settings WebUI: replace paper-tabs with cr-tabs

    Bug: 960564
@mkarolin mkarolin force-pushed the maxk-fix-clear-browsing-data branch from 4731d3c to 7ec1cf4 Compare July 17, 2019 22:03
@mkarolin mkarolin requested review from petemill and bsclifton July 18, 2019 03:29
bsclifton
bsclifton approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄👍

@bsclifton
Copy link
Member

CI looks good - only failures (Build has "yellow" / unstable coloring) are because network audit, which has since been fixed. Good to merge! 😄

@bsclifton bsclifton merged commit ac49f09 into master Jul 18, 2019
@bsclifton bsclifton deleted the maxk-fix-clear-browsing-data branch July 18, 2019 17:49
mkarolin pushed a commit that referenced this pull request Jul 18, 2019
@bsclifton @mkarolin
Merge pull request #2945 from brave/maxk-fix-clear-browsing-data
ab2ed8d 
Fix for Clear Browsing Data dialog not showing.
@mkarolin mkarolin mentioned this pull request Jul 18, 2019
Merged
32 tasks
mkarolin pushed a commit that referenced this pull request Jul 18, 2019
@bsclifton @mkarolin
Merge pull request #2945 from brave/maxk-fix-clear-browsing-data
a350bfb 
Fix for Clear Browsing Data dialog not showing.
@mkarolin mkarolin mentioned this pull request Jul 18, 2019
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.

Chromium 76 upgrade broke Clear Browsing Data dialog
2 participants
@mkarolin @bsclifton