Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62 (0.68.x) #2934

Merged
merged 6 commits into from
Jul 18, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 16, 2019

Fixes brave/brave-browser#5083
Related PR: brave/brave-browser#5263
Uplift request from #2892

Fixes brave/brave-browser#5222
Uplift request from #2903

Fixes brave/brave-browser#5277
Uplift request from #2945

Submitter Checklist:

Test Plan:

See brave/brave-browser#5083

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

mkarolin and others added 4 commits July 16, 2019 11:21
Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62
Affected:

 * WebSocketHandshakeRequestInfo::ForRequest.

Chromium change:

commit d726e1e8a8f5be0cb11128f9980243ef41c18a5a
Author: Lucas Furukawa Gadani <[email protected]>
Date:   Wed May 8 16:20:03 2019 +0000

    Remove const interfaces from content/public API.

    Bug: 908139
@mkarolin mkarolin added this to the 0.68.x - Dev milestone Jul 16, 2019
@mkarolin mkarolin self-assigned this Jul 16, 2019
@mkarolin mkarolin marked this pull request as ready for review July 16, 2019 18:17
@mkarolin mkarolin changed the title Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62 (0.68.x) WIP: Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62 (0.68.x) Jul 16, 2019
@mkarolin mkarolin changed the title WIP: Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62 (0.68.x) Upgrade from Chromium 75.0.3770.100 to Chromium 76.0.3809.62 (0.68.x) Jul 16, 2019
@mkarolin
Copy link
Collaborator Author

The only CI error is uploading unit tests results.

@mkarolin mkarolin requested review from bridiver, bsclifton and a team July 16, 2019 21:37
@mkarolin
Copy link
Collaborator Author

Ideally, we'd want #2903 uplifted here as well.

mkarolin and others added 2 commits July 18, 2019 14:09
Follow up on comments for c76 update
Fix for Clear Browsing Data dialog not showing.
@mkarolin
Copy link
Collaborator Author

The only CI failures I see are the network audit and the unit tests results publishing.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @rebron - we're both ++ on this 😄 CI looks good! Thanks, @mkarolin!

@bsclifton bsclifton merged commit 822a96b into 0.68.x Jul 18, 2019
@bsclifton bsclifton deleted the 76.0.3809.62-0.68.x branch July 18, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants