Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix URL-Bar typing when the URL belongs to a bookmark #26359

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Brandon-T
Copy link
Contributor

Summary

  • When the classifier returns bookmarkTitle, it has a DestinationURL of that bookmark which should be searched since it's a 100% match. Following Chromium, I've added OpenTab, historyURL, and bookmarkTitle.

Resolves brave/brave-browser#41910

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 4, 2024
@Brandon-T Brandon-T self-assigned this Nov 4, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner November 4, 2024 19:14
@Brandon-T Brandon-T merged commit d8b1d4a into master Nov 4, 2024
18 checks passed
@Brandon-T Brandon-T deleted the bugfix/BookmarksURLBar branch November 4, 2024 20:57
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Nov 4, 2024
brave-builds added a commit that referenced this pull request Nov 4, 2024
brave-builds added a commit that referenced this pull request Nov 4, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.73

@hffvld
Copy link
Collaborator

hffvld commented Nov 5, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.73 (75)
BraveCore: 1.73.75 (131.0.6778.24)

STEPS:

  1. Launch Brave
  2. Go to any website, for example, https://bbc.com
  3. Add website to Bookmarks
  4. Open NTP > Type https://bbc.com again
  5. Tap Enter > Verify

ACTUAL RESULTS:

  • Verified that the expected website is opened when it has already been added to Bookmarks.
  • Verified that the website can be added to Bookmarks and opened via Open Tabs & Bookmarks & History.

1 2 3 4
1 2 3 4
2024-11-05_12-46-10.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarking a base URL results in URL being sent to search engine
5 participants