Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarking a base URL results in URL being sent to search engine #41910

Closed
2 of 5 tasks
z01L opened this issue Oct 26, 2024 · 4 comments · Fixed by brave/brave-core#26359
Closed
2 of 5 tasks

Bookmarking a base URL results in URL being sent to search engine #41910

z01L opened this issue Oct 26, 2024 · 4 comments · Fixed by brave/brave-core#26359

Comments

@z01L
Copy link

z01L commented Oct 26, 2024

Description

Bookmarking a base URL(eg. bbc.com) will break opening the site from the URL bar

Steps to reproduce

  1. Go to bbc.com and add it to your bookmarks
  2. Open a new tab
  3. In the URL bar, type in bbc.com and press return on the keyboard

Actual result

Brave google searches bbc.com

Image

Expected result

Brave opens https://www.bbc.com

Reproduces how often

Easily reproduced

Brave version

Version 1.70 (131)

Device/iOS version

iPhone 13 Pro Max/iOS 18.0.1

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@whenceforth
Copy link

Happens for me also on iPhone Pro 15 with iOS 17.7.1 and Brave Version 1.70.1 (133)

@split3ie
Copy link

split3ie commented Nov 1, 2024

On iPhone 11 with iOS 18.1 and Brave Version 1.70 (131) BraveCore faced the issue as well

@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2024

The above requires 1.72.97 or higher for 1.72.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 7, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 7, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.73 (86)
BraveCore: 1.73.86 (131.0.6778.39)

STEPS:

  1. Follow the STR/TP from Bookmarking a base URL results in URL being sent to search engine #41910 (comment) and [iOS] - Fix URL-Bar typing when the URL belongs to a bookmark brave-core#26359 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the expected website is opened when it has already been added to Bookmarks.
  • Verified that the website can be added to Bookmarks and opened via Open Tabs & Bookmarks & History.

1 2 3 4
1 2 3 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants