Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Use Leo Side Nav in Wallet #25530

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Douglashdaniel
Copy link
Contributor

Description

The Wallet Desktop will now use the leo side nav component.

Resolves brave/brave-browser#40913

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet desktop
  2. You will see the new Side Nav
  3. Test all nav options and make sure they route correctly
  4. Collapse your Browser window width and make sure that the side nave disappears when shrunk.

Screenshot 25

Screen.Recording.2.mov

@Douglashdaniel Douglashdaniel self-assigned this Sep 11, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner September 11, 2024 18:32
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 11, 2024
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Douglashdaniel Douglashdaniel force-pushed the feat-wallet-use-leo-side-nav-in-wallet branch from d301580 to 36aa3fa Compare September 11, 2024 19:27
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 0d9a355 into master Sep 11, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the feat-wallet-use-leo-side-nav-in-wallet branch September 11, 2024 21:18
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new Wallet Side bar navigation
3 participants