Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new Wallet Side bar navigation #40913

Closed
Douglashdaniel opened this issue Sep 6, 2024 · 1 comment · Fixed by brave/brave-core#25530
Closed

Implement new Wallet Side bar navigation #40913

Douglashdaniel opened this issue Sep 6, 2024 · 1 comment · Fixed by brave/brave-core#25530
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.73.x - Release

Comments

@Douglashdaniel
Copy link

Platforms

Linux, macOS, Windows

Description

We need to update the Wallet Side Bar to the new design in figma https://www.figma.com/design/muVcmcu4RFNu0LkXe9VRDl/Wallet-2.0?node-id=19360-188914&node-type=FRAME&t=Mt18VX5ZmI9rv8eN-0

Screenshot 12
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Sep 6, 2024
@Douglashdaniel Douglashdaniel self-assigned this Sep 6, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Sep 6, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Sep 11, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Sep 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Sep 11, 2024
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Sep 11, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
Revision 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS Windows 11 Version 23H2 (Build 22631.4317)
  • Verified steps from brave/brave-core#25530
  • Verified Wallet sidebar is fixed on the left side
  • Verified wallet sidebar navigation works as expected
  • Verified reducing the browser window size hides side navigation when browser window reaches its limit
40913-Win.mp4

Verification passed on

Brave 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
Revision 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS Linux
  • Verified steps from brave/brave-core#25530
  • Verified Wallet sidebar is fixed on the left side
  • Verified wallet sidebar navigation works as expected
  • Verified reducing the browser window size hides side navigation when browser window reaches its limit
40913.mp4

Verification passed on

Brave 1.72.82 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
Revision 4f0233b15f1896e28ff5ce439de1f658a2ef2df0
OS macOS Version 15.0.1 (Build 24A248)
  • Verified steps from brave/brave-core#25530
  • Verified Wallet sidebar is fixed on the left side
  • Verified wallet sidebar navigation works as expected
  • Verified reducing the browser window size hides side navigation when browser window reaches its limit

@LaurenWags LaurenWags mentioned this issue Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Use Leo Side Nav in Wallet brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds