[iOS] Edit Custom Search Engines

[soner-yuksel]

Resolves brave/brave-browser#39552

This PR is adding the functionality of edit to custom search screen and engines.

In addition to delete now edit is added to the swipe functionality. The same screen is used including the same error checks for this action except the duplicate error check since the engine is edited. In addition the view controller functionality is divided into chunks to make edit easier for next iteration.

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

• Add custom search engine
• Use the template search engine mentioned in the description
• Try edit functionality and change url or title
• Check if the changes are done
• Test query with them

Screenshots:

RPReplay_Final1722714552.mov

[github-actions]

[puLL-Merge] - brave/brave-core@24856

Description

This PR introduces significant changes to the search engine management functionality in the Brave iOS app. It refactors and enhances the custom search engine addition and editing features, improving the user interface and overall functionality.

Changes

Changes

1. BrowserViewController.swift:

   • Updated references from SearchSettingsTableViewController to SearchSettingsViewController.

2. SearchEngines.swift:

   • Added a new editSearchEngine method to allow editing of existing custom search engines.

3. CustomEngineTableViewHeader.swift:

   • New file added to create a custom header for the search engine table view.

4. CustomEngineTitleInputTableViewCell.swift:

   • New file added to create a custom cell for inputting search engine titles.

5. CustomEngineURLInputTableViewCell.swift:

   • New file added to create a custom cell for inputting search engine URLs.

6. CustomEngineViewController+OpenSearch.swift:

   • New file added to handle OpenSearch functionality for custom search engines.

7. CustomEngineViewController.swift:

   • Renamed from SearchCustomEngineViewController.swift.
   • Significant refactoring and enhancement of the custom search engine management functionality.
   • Added support for editing existing search engines.

8. SearchEnginePickerViewController.swift:

   • Renamed from SearchEnginePicker.swift.

9. SearchSettingsViewController.swift:

   • Renamed from SearchSettingsTableViewController.swift.
   • Added swipe actions for editing and deleting custom search engines.
   • Updated to use the new CustomEngineViewController for adding and editing engines.

10. SettingsViewController.swift:

    • Updated reference to SearchSettingsViewController.

11. BraveStrings.swift:

    • Updated string references to reflect the new class names.

Possible Issues

• The refactoring and renaming of classes may require updates in other parts of the codebase that are not shown in this diff.
• Thorough testing should be performed to ensure that all search engine management functionality works as expected, especially the new editing feature.

Security Hotspots

No significant security issues are apparent in this change. However, care should be taken when handling user-inputted URLs and search engine data to prevent potential injection attacks or malformed URLs.

[iccub]

nice one