Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit custom search engines #39552

Closed
3 tasks done
soner-yuksel opened this issue Jul 3, 2024 · 1 comment · Fixed by brave/brave-core#24856
Closed
3 tasks done

Edit custom search engines #39552

soner-yuksel opened this issue Jul 3, 2024 · 1 comment · Fixed by brave/brave-core#24856

Comments

@soner-yuksel
Copy link

soner-yuksel commented Jul 3, 2024

Description

We dont have edit functionality for custom search engines. We have add and delete but there is edit. This issue is mentioned in ios channel, creating a follow up issue.

The Add screen can be used for Edit functionality and swipe action can be added next to delete swipe action.

Steps to reproduce

  1. Open Settings - SearchEngines
  2. Try to edit a custom search Engine

Actual result

The custom search engines are editable.

Expected result

They should be editable and the functionality should be added to swipe actions.

2123321

Reproduces how often

Easily reproduced

Brave version

1.67

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight
@hffvld
Copy link
Contributor

hffvld commented Sep 24, 2024

Verified on iPhone 14 and iPad Mini (6th gen) using version(s):

Device/OS:
- iPhone 14 / iOS 17.7
- iPad Mni (6th gen) / iPadOS 18
Brave build: 1.70 (117)
BraveCore: 1.70.117 (129.0.6668.59)

Filed follow-up issue #41210 and #41228

STEPS:

  1. Launch Brave
  2. Hamburger menu > Settings
  3. Search Engines > Add Custom Search Engine
  4. In URL type https://youtube.com/search?q=%s and in Title type YT > Done
  5. Slide the newly created SE to the left > Verify Edit button exists
  6. Tap Edit > Update the URL / Title > Save the changes by tapping the button in the top right corner

ACTUAL RESULTS:

  • Verified that the Edit button is shown for the custom SE.
  • Verified that the custom SE can be edited by tapping the Edit button.
  • Verified that no regression happened: custom SE can be set as default for Standard / Private tabs, and search results are shown with that SE.

iPhone 14 / iOS 17.7

1 2 3 4 5
1 2 3 4 5

iPad Mni (6th gen) / iPadOS 18

1 2 3 4 5
1 2 3 4 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants