[Follow up to #39552] Title for Edit button needs to be updated to Done when editing custom SE

[hffvld]

Description

Follow-up to #39552.

Steps to reproduce

1. Launch Brave
2. Hamburger menu > Settings
3. Search Engines > Add Custom Search Engine
4. In URL type https://youtube.com/search?q=%s and in Title type YT > Done
5. Slide the newly created SE to the left > Tap Edit
6. Update the Title > Observe

Actual result

If editing custom SE (any of URL or Title), the button title (top right corner) says Edit instead of Done.

---

1	2

Expected result

The title for Edit button needs to be updated to Done when editing custom SE.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.70 (117)
BraveCore: 1.70.117 (129.0.6668.59)

Device/iOS version

iPad Mni (6th gen) / iPadOS 18

Affected browser versions

• latest AppStore
• latest TestFlight
• previous TestFlight

Reproducibility

• with Brave Shields disabled
• in the latest version of mobile Safari

Miscellaneous information

No response

[kylehickinson]

It seems like it was explicitly set to "Edit" instead of "Done" when editing a custom search engine. Do we want to go back to "Done" here? Not sure on reasoning cc @jamesmudgett @timchilds

[timchilds]

@kylehickinson Done makes sense to me 👍

The user cannot save the custom engine edits until they press the button right?

[kylehickinson]

@timchilds Correct, they have to tap the button to save whatever changes they've made in the form

[hffvld]

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.1
Brave build: 1.72 (93)
BraveCore: 1.72.93 (131.0.6778.14)

---

STEPS:

1. Follow the STR/TP from [Follow up to #39552] Title for Edit button needs to be updated to Done when editing custom SE #41210 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that the title for the Edit button is updated to Done when editing custom SE.

---

1	2	3