Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tooltip texts for toggle button on vertical tabs #17974

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Apr 10, 2023

Resolves brave/brave-browser#29593

  • While expanded

image

  • While floating

image

  • While minimized

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Enable vertical tabs
  • Move mouse on the toggle button on the top of vertical tab strip.
  • See if tooltip texts aren't empty

@sangwoo108 sangwoo108 marked this pull request as ready for review April 10, 2023 05:16
@sangwoo108 sangwoo108 requested a review from petemill April 10, 2023 05:16
@sangwoo108 sangwoo108 merged commit d5a7601 into master Apr 11, 2023
@sangwoo108 sangwoo108 deleted the sko/vtab-tooltip branch April 11, 2023 03:51
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 11, 2023
brave-builds added a commit that referenced this pull request Apr 11, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.52.35 Chromium: 112.0.5615.49 (Official Build) nightly (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 13.4 (Build 22F5027f)

Steps:

  1. install 1.52.35
  2. launch Brave
  3. loaded mozilla.com
  4. loaded https://en.wikipedia.org/wiki/Latin_alphabet
  5. context-clicked on the 1st tab
  6. chose Use vertical tabs
  7. hovered over (and clicked on) the "sidebar"/"side panel" button, to expand
  8. confirmed the tooltip reads Minimize Tabs
  9. pinned tabs
  10. hovered over the button again
  11. confirmed the tooltip reads Minimize Tabs
  12. clicked again to minimize
  13. confirmed the tooltip reads Expand Tabs
while expanded, Minimize Tabs while floating, Minimize Tabs while minimized, Expand Tabs
Screenshot 2023-04-11 at 9 44 50 PM Screenshot 2023-04-11 at 9 48 06 PM Screenshot 2023-04-11 at 9 44 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical tab strip's toggle button doesn't have tooltip
3 participants