Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical tab strip's toggle button doesn't have tooltip #29593

Closed
sangwoo108 opened this issue Apr 10, 2023 · 3 comments · Fixed by brave/brave-core#17974
Closed

Vertical tab strip's toggle button doesn't have tooltip #29593

sangwoo108 opened this issue Apr 10, 2023 · 3 comments · Fixed by brave/brave-core#17974
Assignees
@sangwoo108
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented Apr 10, 2023 •
edited
Loading

image

Should be minimize tabs / expand tabs

As Vertical tab strip feature flag is enabled by default, we should uplift this to Beta.
@sangwoo108 sangwoo108 self-assigned this Apr 10, 2023
@sangwoo108 sangwoo108 added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 10, 2023
@sangwoo108 sangwoo108 mentioned this issue Apr 10, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 11, 2023
@brave-builds brave-builds mentioned this issue Apr 11, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.51.86 or higher for 1.51.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 12, 2023
@stephendonner
Copy link

The above requires 1.51.86 or higher for 1.51.x verification 👍

Actually, it needs a version higher, even:

Screen Shot 2023-04-12 at 9 57 19 AM

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 12, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.51.87 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2846)

Steps:

Followed brave/brave-core#17974 (comment)

while expanded, Minimize Tabs while floating, Minimize Tabs while minimized, Expand Tabs
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Set tooltip texts for toggle button on vertical tabs brave/brave-core
4 participants
@stephendonner @kjozwiak @sangwoo108 @brave-builds