Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opaque color for tab background in dark mode tab strip #17846

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

sangwoo108
Copy link
Contributor

When the color has opacity, the hover glow effect's color will be multiplied, which ends up with too strong effect. In order to avoid that use opaque color by blending tab's background and tab strip background color.

Resolves brave/brave-browser#29436

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

When the color has opacity, the hover glow effect's color will be
multiplied, which ends up with too strong effect. In order to avoid that
use opaque color by blending tab's background and tab strip background
color.
@sangwoo108 sangwoo108 enabled auto-merge (squash) March 31, 2023 05:37
@sangwoo108 sangwoo108 merged commit 6986aa4 into master Mar 31, 2023
@sangwoo108 sangwoo108 deleted the sko/vtab-bg branch March 31, 2023 07:26
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Mar 31, 2023
brave-builds added a commit that referenced this pull request Apr 1, 2023
@stephendonner
Copy link
Contributor

stephendonner commented Apr 7, 2023

Verification PASSED using

Brave 1.52.25 Chromium: 112.0.5615.49 (Official Build) nightly (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

First, reproduced the heavy hover effect using 1.51.79:

Brave 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)

Steps:

  1. set macOS to Dark Mode
  2. installed 1.151.79
  3. launched Brave
  4. loaded a couple pages
  5. context-clicked on the tab's titlebar
  6. chose Use vertical tabs
  7. noted default (unselected) state and on hover states for tabs
unselected, default state on hover (heavier)
Screen Shot 2023-04-07 at 12 34 05 AM Screen Shot 2023-04-07 at 12 34 08 AM

Confirmed FIXED using 1.52.25:

Steps:

  1. installed 1.152.25
  2. launched Brave
  3. loaded a couple pages
  4. context-clicked on the tab's titlebar
  5. chose Use vertical tabs
  6. noted default (unselected) state and on hover states for tabs

Confirmed a lighter hover-state effect, matching that in brave/brave-browser#29436 (comment) 👍

unselected, default state on hover (lighter)
Screen Shot 2023-04-07 at 12 39 17 AM Screen Shot 2023-04-07 at 12 39 21 AM

kjozwiak pushed a commit that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab hover glow effect in dark mode is too strong
3 participants