Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab hover glow effect in dark mode is too strong #29436

Closed
sangwoo108 opened this issue Mar 31, 2023 · 2 comments · Fixed by brave/brave-core#17846
Closed

Tab hover glow effect in dark mode is too strong #29436

sangwoo108 opened this issue Mar 31, 2023 · 2 comments · Fixed by brave/brave-core#17846
Assignees
@sangwoo108
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.51.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented Mar 31, 2023 •
edited
Loading

image

In Vertical tab strip with dark mode, when you move mouse over to inactive tabs, the glow effect is too strong, We should use softer color just like in light mode

Happens on Nightly and Beta

Now it should look like
image
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude OS/Desktop feature/vertical-tabs labels Mar 31, 2023
@sangwoo108 sangwoo108 self-assigned this Mar 31, 2023
@sangwoo108 sangwoo108 mentioned this issue Mar 31, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 31, 2023
@brave-builds brave-builds mentioned this issue Apr 1, 2023
Merged
7 tasks
@sangwoo108 sangwoo108 added QA/Yes and removed QA/No labels Apr 1, 2023
@kjozwiak
Copy link
Member

The above requires 1.51.86 or higher for 1.51.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 12, 2023
@stephendonner
Copy link

Verification PASSED using

Brave 1.51.86 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.51.86
  2. launched Brave
  3. opened brave://flags
  4. set brave://flags/#brave-vertical-tabs to Enabled
  5. clicked Relaunch
  6. loaded brave.com
  7. loaded mozilla.org
  8. context-clicked on the brave.com tab
  9. chose Use Vertical Tabs
  10. set Brave colors in brave://settings/appearance to Dark
  11. hovered over the tabs

Confirmed a much lighter, but still noticeable highlight effect on hover

default on hover
Screen Shot 2023-04-12 at 9 37 57 AM Screen Shot 2023-04-12 at 9 38 26 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Use opaque color for tab background in dark mode tab strip brave/brave-core
4 participants
@stephendonner @kjozwiak @sangwoo108 @brave-builds