Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SessionProfile leftover completely #15496

Merged
merged 1 commit into from
Oct 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions browser/profiles/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ source_set("profiles") {
"brave_bookmark_model_loaded_observer.h",
"brave_profile_avatar_downloader.cc",
"brave_profile_avatar_downloader.h",
"brave_profile_impl.cc",
"brave_profile_impl.h",
"brave_profile_manager.cc",
"brave_profile_manager.h",
"brave_renderer_updater.cc",
Expand All @@ -19,13 +17,6 @@ source_set("profiles") {
"brave_renderer_updater_factory.h",
]

if (is_win) {
sources += [
"brave_profile_shortcut_manager_win.cc",
"brave_profile_shortcut_manager_win.h",
]
}

public_deps = [ ":util" ]

deps = [
Expand Down
58 changes: 0 additions & 58 deletions browser/profiles/brave_profile_impl.cc

This file was deleted.

38 changes: 0 additions & 38 deletions browser/profiles/brave_profile_impl.h

This file was deleted.

11 changes: 0 additions & 11 deletions browser/profiles/brave_profile_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,6 @@ BraveProfileManager::BraveProfileManager(const base::FilePath& user_data_dir)
MigrateProfileNames();
}

BraveProfileManager::~BraveProfileManager() {
std::vector<Profile*> profiles = GetLoadedProfiles();
for (Profile* profile : profiles) {
if (brave::IsSessionProfile(profile)) {
// passing false for `success` removes the profile from the info cache
OnProfileCreationFinished(profile, Profile::CREATE_MODE_ASYNCHRONOUS,
false, false);
}
}
}

void BraveProfileManager::InitProfileUserPrefs(Profile* profile) {
// migrate obsolete plugin prefs to temporary migration pref because otherwise
// they get deleteed by PrefProvider before we can migrate them in
Expand Down
1 change: 0 additions & 1 deletion browser/profiles/brave_profile_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class BraveProfileManager : public ProfileManager {
explicit BraveProfileManager(const base::FilePath& user_data_dir);
BraveProfileManager(const BraveProfileManager&) = delete;
BraveProfileManager& operator=(const BraveProfileManager&) = delete;
~BraveProfileManager() override;

void InitProfileUserPrefs(Profile* profile) override;
void SetNonPersonalProfilePrefs(Profile* profile) override;
Expand Down
41 changes: 0 additions & 41 deletions browser/profiles/brave_profile_shortcut_manager_win.cc

This file was deleted.

30 changes: 0 additions & 30 deletions browser/profiles/brave_profile_shortcut_manager_win.h

This file was deleted.

Loading