Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SessionProfile leftover completely #15496

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 17, 2022

Resolves brave/brave-browser#26085

It removed Session Profile implementation from #3319 and #3794 which are no longer needed when we make Tor as OTR profile

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@darkdh darkdh requested review from bridiver, yrliou and emerick October 17, 2022 21:02
@darkdh darkdh self-assigned this Oct 17, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Oct 17, 2022
@darkdh darkdh marked this pull request as ready for review October 17, 2022 21:03
@darkdh darkdh requested review from a team as code owners October 17, 2022 21:03
@darkdh darkdh force-pushed the remove-session-profile branch from f397d31 to cfc13ca Compare October 17, 2022 22:19
@darkdh darkdh merged commit a63e5aa into master Oct 18, 2022
@darkdh darkdh deleted the remove-session-profile branch October 18, 2022 00:21
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Session Profile leftover
2 participants