Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Use lld when compiling iOS, fixing a crash on release builds (uplift to 1.38.x) #12786

Merged
merged 1 commit into from
Mar 29, 2022
Merged

[iOS] Use lld when compiling iOS, fixing a crash on release builds (uplift to 1.38.x) #12786

merged 1 commit into from
Mar 29, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 28, 2022 •
edited by kjozwiak
Loading

Uplift of #12774
Resolves brave/brave-browser#21925

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from a team and bridiver as code owners March 28, 2022 20:35
@brave-builds brave-builds requested a review from a team March 28, 2022 20:35
@brave-builds brave-builds self-assigned this Mar 28, 2022
@brave-builds brave-builds added this to the 1.38.x - Beta milestone Mar 28, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 29, 2022 •
edited
Loading

Win failed test-browser due to RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted which is a known intermittent issue that was just fixed via brave/brave-browser#21809. Doesn't block uplift.

kjozwiak
kjozwiak approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍

@kjozwiak kjozwiak merged commit a18d95f into 1.38.x Mar 29, 2022
@kjozwiak kjozwiak deleted the pr12774_ios-runtime-crash-lld_1.38.x branch March 29, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases