Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Use lld when compiling iOS, fixing a crash on release builds #12774

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Mar 26, 2022

Also updates and removes some GN args

Resolves brave/brave-browser#21925

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added this to the 1.39.x - Nightly milestone Mar 26, 2022
@kylehickinson kylehickinson requested a review from bridiver as a code owner March 26, 2022 05:55
@kylehickinson kylehickinson self-assigned this Mar 26, 2022
@kylehickinson kylehickinson force-pushed the ios-runtime-crash-lld branch from eb51ea3 to 818184b Compare March 28, 2022 14:22
@kylehickinson kylehickinson requested a review from a team as a code owner March 28, 2022 14:22
@kylehickinson
Copy link
Collaborator Author

Ignoring windows CI as its continued to fail with unrelated tests and the third build did succeed before rebase https://ci.brave.com/job/pr-brave-browser-ios-runtime-crash-lld-windows/3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS arm64 release builds crash on launch when building with clang 15
3 participants