Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add EIP-55 checksum address checks in Send widget #11607

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Dec 15, 2021

Resolves brave/brave-browser#19532.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

Screen.Recording.2021-12-15.at.6.38.17.PM.mov

@onyb onyb requested review from Douglashdaniel, muliswilliam and a team December 15, 2021 13:21
@onyb onyb self-assigned this Dec 15, 2021
@onyb onyb force-pushed the f/wallet/checksum-address-error branch from 84e32e9 to 2ae8aac Compare December 15, 2021 13:37
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@onyb onyb force-pushed the f/wallet/checksum-address-error branch from 2ae8aac to a40e050 Compare December 15, 2021 16:06
@onyb onyb requested a review from muliswilliam December 15, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants