Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an extra validation of ETH address #20132

Closed
SergeyZhukovsky opened this issue Dec 16, 2021 · 1 comment · Fixed by brave/brave-core#11737
Closed

Add an extra validation of ETH address #20132

SergeyZhukovsky opened this issue Dec 16, 2021 · 1 comment · Fixed by brave/brave-core#11737
Assignees
@wchen342
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

Create a validation the same way as desktop did #19532
@SergeyZhukovsky SergeyZhukovsky added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Dec 16, 2021
@wchen342 wchen342 mentioned this issue Jan 4, 2022
Merged
25 tasks
@wchen342 wchen342 added this to the 1.36.x - Nightly milestone Jan 5, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2022

Verification passed on Oppo Reno 5 with Android 11 running 1.36.85 x64 Beta build

  • Verified steps from brave/brave-core#11607
  • Verified error is shown when an invalid ETH addres is entered
  • Verified error is shown when an address has missing checksum
  • Verified error is shown when an address has invalid checksum
  • Encountered #20930
Not a valid ETH Invalid checksum Missing checksum
image image image

Verification passed on Samsung Tab A with Android 10 running 1.36.85 x64 Beta build

  • Verified steps from brave/brave-core#11607
  • Verified error is shown when an invalid ETH addres is entered
  • Verified error is shown when an address has missing checksum
  • Verified error is shown when an address has invalid checksum
  • Encountered #20930
Not a valid ETH Invalid checksum Missing checksum
image image image

@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wchen342 wchen342

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Add ETH send address checksum validation brave/brave-core
4 participants
@bbondy @wchen342 @SergeyZhukovsky @srirambv